Cannot save or load chat settings

frtoaster

The command /ui_save_file no longer saves chat settings to UI files, and the command /ui_load_file no longer loads chat settings from UI files. This bug also affects the commands /ui_save and /ui_load, as well as the "Save UI" and "Load UI" buttons in the "HUD" tab of the options window (see the screenshots below).

http://i.imgur.com/eNjuN9D.png
http://i.imgur.com/0Z5ikmn.png

Note that while the command /ui_save_file writes to a file named by the user, the command /ui_save and the "Save UI" button always write to the file ui_settings.txt. Similarly, the command /ui_load_file reads from a file named by the user, but the command /ui_load and the "Load UI" button always read from the file ui_settings.txt.

Steps to reproduce

1. Install the following build:

Version: ST.64.20160709a.32
SVN build number: 200474
Holodeck patch date: September 29, 2016

2. Start the STO client and log on to a character in system space.
3. Enter the following command in the chat window:

/ui_save_file ui_test1.txt

4. Make a copy of the file ui_test1.txt and rename the copy to ui_test2.txt.
5. Open ui_test2.txt in a text editor.
6. Find the section named "pChatConfig". Within that section, find the subsection named "eaChatTabGroupConfigs".
7. Within "eaChatTabGroupConfigs", find the line containing "CurrentTab" followed by a number.
8. Above the line containing "CurrentTab", insert the following text:

		eaChatTabConfigs
		{
			Title Test
			DefaultChannel Local
			MessageType Local
		}

9. Save your changes to ui_test2.txt and exit the text editor.
10. In the STO client, enter the following command in the chat window:

/ui_load_file ui_test2.txt

11. Verify that the chat window contains a new tab named "Test".
12. Enter the following command in the chat window:

/ui_load_file ui_test1.txt

13. Verify that the "Test" tab is gone from the chat window.
14. Exit the STO client.
15. Install the following build:

Version: ST.66.20160925a.3
SVN build number: 200688
Tribble patch date: September 30, 2016

16. Copy the files ui_test1.txt and ui_test2.txt to the directory where you installed the new build.
17. Start the STO client and log on to the same character as before, starting in the same system as before.
18. Enter the following command in the chat window:

/ui_load_file ui_test1.txt

19. Wait 10 seconds. Then, enter the following command in the chat window:

/ui_save_file ui_test3.txt

20. Compare the files ui_test1.txt and ui_test3.txt.
21. Notice that the section "pChatConfig" is missing from ui_test3.txt.
22. Enter the following command in the chat window:

/ui_load_file ui_test2.txt

23. Observe that the above command failed to add a new tab named "Test" to the chat window.
24. Repeat steps 1 through 23 using /ui_save and /ui_load instead of /ui_save_file and /ui_load_file, renaming the files as appropriate.
25. Repeat steps 1 through 23 using the "Save UI" and "Load UI" buttons instead of /ui_save_file and /ui_load_file, renaming the files as appropriate.

frtoaster

I've discovered that the command /ui_load_file does not load chat settings. The bug also affects the commands /ui_save and /ui_load, as well as the "Save UI" and "Load UI" buttons. I've changed the bug report to reflect this new information.