test content
What is the Arc Client?
Install Arc

Advanced Combat Tracker plugin for Neverwinter. Updates Feb 2018

dragonsbitedragonsbite Member Posts: 37 Arc User
edited February 12 in Guides
I changed a few things that were bothering me and I wanted more accuracy.

-EDIT-The download link below is the lastest version which i'll keep changing as we change it in this thread and as long as i'm playing.

Download it here-->Neverwinter 2-11-2018


Here's the change log below.

/* Version History - dragonsbite
* 1.2.6.0 - 2-11-2018
* - Changed processing order to fix some things. Removed the previous Wheel of Elements : Earth fix as this fix fixes it and as below and other stuff.
* - Fixed Cleanse to show the correct amount of inc Cleanse and out Cleanse
* - Fixed Fall Damage to not start combat
* - Fixed Spike Trap, Poison Spike Trap, and Arrow Trap to not start combat.
* 1.2.5.0 - 2-9-2018
* -Fixed Falling Damage to not start combat.
* -Fixed Wheel of Elements : Earth to not start combat.
* 1.2.4.0 - 2-9-2018
* - Fixed Pet Damage "In and "Out" and "Deaths". This affects your damage in and out by less then 0.05% and your deaths.
* - Fixed Cure/Dispel In and Out to only show "Cleanse" and ignored others that did NOT show a cleanse and instead just showed messages of expiration.
* - Fixed "Start" and "Stop" of combat to now start and stop via actual damage as it properly should. Encounter times are decreased as a result.
* - Consequently dps increases as it should. The amount of encounters increases as there is more time between encounters now.
*/

/* Version History - designedbyrng
* 1.2.3.0 - 2-8-2018
* - Non-damaging procs are in their own category "Non-Damage (Out)" and "Non-Damage (Inc)"
* - Fixed Slayer marks now are parsed properly
* - Several stats have been renamed to fit neverwinter better
*/

Apologies @thefabricant I could not figure out how to make a proc category and I probably never will. Oh well :p
-edit-designedbyrng added this.

A special thanks to @designedbyrng#4319 for the newest work and nils.brummond as he did quite a bit of work on the previous versions and credit goes to Antday, Hilbert, Pirye for theirs as well. This is my final version for this one. Doubt i'll ever update it again.

I'll post some before and after pics when I can.
Post edited by dragonsbite on

Comments

  • dragonsbitedragonsbite Member Posts: 37 Arc User
    Reserved as I may need it if I create an ACT guide.
  • designedbyrng#4319 designedbyrng Member Posts: 99 Arc User
    edited February 7
    @dragonsbite
    Apologies @thefabricant I could not figure out how to make a proc category and I probably never will. Oh well :p

    you mean like this?
    https://hastebin.com/hejefeyono.cpp

    This is based on the original from github, not yours.

    Changes:
    -non-damaging procs are in their own category
    -slayer marks now are parsed properly
    -several stats have been renamed to fit neverwinter better
  • dragonsbitedragonsbite Member Posts: 37 Arc User
    @designedbyrng#4319 , Thanks i'll check that later and compare them. Maybe incorporate the 2. There's no version history of the changes you mentioned. When was this done or is there a forum post somewhere about it I can read? thanks
  • designedbyrng#4319 designedbyrng Member Posts: 99 Arc User
    @dragonsbite
    I simply opened it and started tinkering with stuff.
  • dragonsbitedragonsbite Member Posts: 37 Arc User
    edited February 8
    @designedbyrng#4319 Well it's way better then what I came up with. Not a programmer here at all. I noticed by comparing the 2 that a couple abilities weren't being tracked correctly with mine. It was very minimal but still incorrect. So i'm removing mine. Personally i'd rather they based it off of Aria's STO plugin instead of Hilbert's STO plugin.

    I did notice that yours ended combat via heals or regen or power or whatever it was, sorry i forget which, when it should have been damage. Mine started and ended the encounter with damage after say 14.8 seconds total encounter time and yours ended combat after 18.8 seconds total encounter time. Consequently our encounter dps is different. One reason I was fiddling with the plugin. Now when I have "heals extend encounter" selected it should be exactly as yours showed.

    I you want to fiddle around some more then see if you can fix that. Would be much appreciated. My fix for that is what caused those 2 abilities not to show correctly i believe.
  • designedbyrng#4319 designedbyrng Member Posts: 99 Arc User
    edited February 8
    @dragonsbite
    I didn't mess with the encounter start/stop parts of the plugin. These were likely caused by a different starting version. All I changed was that damaging attacks were using the default value of the ParsedLine class (NonMelee) and non-damaging procs were being registered manually (to NonMelee). I switched the damage procs to use a different swing type (Melee), and then renamed the different stats to match Neverwinter more clearly.

    I will look into Aria's STO plugin. It might be easier for me to adapt it into something workable than to make my own, which I am considering.
  • dragonsbitedragonsbite Member Posts: 37 Arc User
    edited February 9
    I modified yours a bit by turning on "non-damage inc". meh why not. I also changed the order in "Combatant View" as I wanted "Damage (Out)" on top. So used to it when using act in other games. Moved "non-damage out" to above "all ref out". And non-damage inc" is above "all ref inc". Added version history as well.

    update is here--> Neverwinter 2-8-2018a

    Oh I added one of my old changes to only show a "Cleanse" and ignore others that just show "attributemodexpire" aka messages. This starts at line 2396.
    Post edited by dragonsbite on
  • dragonsbitedragonsbite Member Posts: 37 Arc User
    edited February 9
    Made another change. This one fixes the encounter time in combat. It now starts and stops with damage. Consequently dps goes up as it should. Oddly total damage out and damage in and deaths were not the same. Previous version and original version I might add was not doing pets that well. If the pet did a "Critical|Flank" it sometimes counted it under flank with crit=false and it also shows up under non flank with crit=true. So it was counting it twice. Pet shielding was also not being counted correctly. It is correct now. Some Pet deaths were missing. We now have more Pet deaths.

    My fixes were in ProcessActionSPDN(ParsedLine l) starting at 2495 and starting at 2544.

    Get this version here-->Neverwinter 2-8-2018b

    @designedbyrng#4319 if my fixes aren't exactly correct please feel free to correct me.
  • dragonsbitedragonsbite Member Posts: 37 Arc User
    edited February 12
    This update just shows revision history. Get it here-->Neverwinter Update 2-9-2018

    * 1.2.3.0 - 2-9-2018 - designedbyrng
    * -non-damaging procs are in their own category "Non-Damage (Out)" and "Non-Damage (Inc)"
    * -slayer marks now are parsed properly
    * -several stats have been renamed to fit neverwinter better

    * 1.2.4.0 - 2-9-2018
    * -Fixed Pet Damage "In and "Out" and "Deaths". This affects your damage in and out by less then 0.05% and your deaths.
    * -Fixed Cure/Dispel In and Out to only show "Cleanse" and ignored others that did NOT show a cleanse and instead just showed messages of expiration.
    * -Fixed "Start" and "Stop" of combat to now start and stop via actual damage as it properly should. Encounter times are decreased as a result.
    * -Consequently dps increases as it should. The amount of encounters increases as there is more time between encounters now.
    Post edited by dragonsbite on
  • dragonsbitedragonsbite Member Posts: 37 Arc User
    edited February 12
    Made a few more changes. Get it here-->Neverwinter Update 2-9-2018b

    * 1.2.5.0 - 2-9-2018
    * -Fixed Falling Damage does not start combat.
    * -Fixed Wheel of Elements : Earth does not start combat.
    Post edited by dragonsbite on
  • dragonsbitedragonsbite Member Posts: 37 Arc User
    More changes here-->Neverwinter 2-11-2018

    * 1.2.6.0 - 2-11-2018
    * - Changed processing order to fix some things. Removed the previous Wheel of Elements : Earth fix as this fix fixes it and as below and other stuff.
    * - Fixed Cleanse to show the correct amount of inc Cleanse and out Cleanse
    * - Fixed Fall Damage to not start combat
    * - Fixed Spike Trap, Poison Spike Trap, and Arrow Trap to not start combat.
  • nisckisnisckis Member, NW M9 Playtest Posts: 337 Arc User
    I just uploaded all these changes to a git repository at https://bitbucket.org/nisckis/neverwinter-act-plugin so they are not lost.

    I'll update the repository as new versions are released.


    PS: I added a disclaimer about me not being the one doing the plugin work.

    PS2: I almost forgot, thanks a lot for the work :)
  • dragonsbitedragonsbite Member Posts: 37 Arc User
    edited February 17
    Thanks @nisckis I do appreciate it. Hm, I may steal some or all of your guide to finish mine if that's ok. And yw, I was bored and needed something to do. I can't program so I treat this as a puzzle. I just google a lot.

    Note that when I changed the traps to not start combat that if you are in combat the damage from them is counted.

    Looks like the last patch on preview fixed some Power Names that had a Carriage Return thus causing an error for those spells as it was 2 lines instead of 1. So those were not being parsed as a result. Nice fix.

    Comments, feedback, is it working correctly vs original version, etc would be appreciated.
    Post edited by dragonsbite on
  • nisckisnisckis Member, NW M9 Playtest Posts: 337 Arc User
    Sure you can, I just did some tweaking to the README.md file (which is in Markdown file format) and it magically shows as the overview of the repository :smile: so it's easier to read and follow the steps.
Sign In or Register to comment.